Fix validate_cmd command in java.pp#72
Merged
ekohl merged 1 commit intovoxpupuli:masterfrom Aug 27, 2024
TheKrizz:fix-validatecmd
Merged
Fix validate_cmd command in java.pp#72ekohl merged 1 commit intovoxpupuli:masterfrom TheKrizz:fix-validatecmd
ekohl merged 1 commit intovoxpupuli:masterfrom
TheKrizz:fix-validatecmd
Conversation
ekohl
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
PR fixes wrong validate_cmd command in java.pp file in tag v5.1.0
This Pull Request (PR) fixes the following issues
The validate_cmd used a wrong validate_replacement string.
It should be % not %s.
With %s all files to check via validate_cmd ends with the char s.
So, the validate_cmd will always fail because the filename doesn't match